Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid compile-time dependency with Application.get_env at macro #158

Merged
merged 1 commit into from
Oct 10, 2021
Merged

avoid compile-time dependency with Application.get_env at macro #158

merged 1 commit into from
Oct 10, 2021

Conversation

nickolaich
Copy link
Contributor

moved calls Application.get_env from macro to functions at RepoClient to avoid compile-time dependency and re-compiling it each time for deploying.

@izelnakri
Copy link
Owner

This looks like a nice feature/changes, thank you! I'm going to review it soon!

@izelnakri izelnakri merged commit 5f87312 into izelnakri:main Oct 10, 2021
@izelnakri
Copy link
Owner

LGTM thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izelnakri izelnakri izelnakri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickolaich @izelnakri