Ability to delete multiple features and to initialise existing record #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
marioimr
commented
Jul 8, 2020
marioimr
commented
- change to PaperTrail.Multi.delete/3 to enable reception of model_key and version_key to execute multiple deletions (on the model of Ecto.Multi.insert/3
- add PaperTrail.initialise/2 to have function that explicitly initialise an already existing record into versions table
izelnakri
reviewed
Jul 15, 2020
| @@ -12,6 +12,22 @@ defmodule PaperTrail do | |||
| defdelegate get_versions(model, id, options), to: PaperTrail.VersionQueries | |||
| defdelegate get_current_model(version), to: PaperTrail.VersionQueries | |||
|
|
|||
| @doc """ | |||
| Intialise paper_trail for existing record | |||
There was a problem hiding this comment.
What about this? "Explicitly inserts an already non-versioned existing record into versions table"
izelnakri
reviewed
Jul 15, 2020
lib/paper_trail/multi.ex
Outdated
| @@ -110,11 +110,14 @@ defmodule PaperTrail.Multi do | |||
| def delete( | |||
| %Ecto.Multi{} = multi, | |||
| struct, | |||
| options \\ [origin: nil, meta: nil, originator: nil, prefix: nil] | |||
| options \\ [origin: nil, meta: nil, originator: nil, prefix: nil, model_key: :model, version_key: :version] | |||
Hi @izelnakri, absolutely in the next days I'll add tests as well. Thank you! |
izelnakri
force-pushed
the
master
branch
2 times, most recently
from
a06c813 to
675d502
Compare
|
Hi @marioimr , I'm willing to merge this PR once the asked changes and tests are added. Thanks! |
mayel
added a commit
to bonfire-networks/paper_trail
that referenced
this pull request
Jun 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.