Add configurable threshold for number of lines for big files #2484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izhangzhihao
approved these changes
Jun 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #784 (comment).
This PR adds a text field to the checkbox for "do NOT rainbowify big files", to configure the maximum number of lines for which the plugin will work, if this checkbox is enabled. I've also updated the notification that pops up if a file is larger than that: instead of an "enable rainbowify for big files" button, it's now an "open settings" button, because the user may want to either disable the setting or increase the threshold.
Small implementation note: I'm not sure how the
ids for the form components are generated, so I typed some random hexadecimal values and hope that's fine 🙂