Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardised params for get_queryset_count_before / after #150

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

matthewhegarty
Copy link
Collaborator

Extension to #149 which includes the params passed into the parent method.
This is useful if the override of count needs to depend on other params.

Note this will break the interface released in 0.7.2, which means that anyone who has overridded get_queryset_count_before or get_queryset_count_after will have to update their code. We can change the param order or add kwargs to avoid this if required.

@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2893b14) to head (7a60e85).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #150   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          427       427           
=========================================
  Hits           427       427           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants