Improve slugify that isn't working with some cases #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's take this example string : `This IS- a C/O/MPLEX STRING - look@THAT` According to regular slugifiers (https://slugify.online/), this string slugified should be `this-is-a-complex-string-lookthat` However, with default slugify(), it will returns a strange string with additional dashes, thus, not very slugify-friendly. Here the output : `this-is--a-complex-string---lookatthat` _____________ With the codes changes, slugify() returns the expected string (I just also modified the `remplacements.dart` files to my convenience, but I guess it depends on your system. ____________ **Explanations** Somehow, the `_dupeSpaceRegExp` has been fixed. Then, the substition between the two regexes `_dupeSpaceRegExp` and `_punctuationRegExp` were to fix too; I changed the order. Now works as expected.
kristofb
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's take this example string :
This IS- a C/O/MPLEX STRING - look@THATAccording to regular slugifiers (https://slugify.online/), this string slugified should be
this-is-a-complex-string-lookthatHowever, with default slugify(), it will returns a strange string with additional dashes, thus, not very slugify-friendly.
Here the output :
this-is--a-complex-string---lookatthatWith the codes changes, slugify() returns the expected string (I just also modified the
remplacements.dartfiles to my convenience in order to prevent the '@' to become 'at', but I guess it depends on your system and your expectations)Explanations
_dupeSpaceRegExphas been fixed._dupeSpaceRegExpand_punctuationRegExpwere to fix too; I changed the order. Now works as expected.