Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support notification history #149

Closed
davidosomething opened this issue Nov 10, 2023 · 2 comments
Closed

feat: support notification history #149

davidosomething opened this issue Nov 10, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@davidosomething
Copy link

davidosomething commented Nov 10, 2023

nvim-notify captures notifications so you can review them in a :Notifications command

would be nice if fidget did the same, maybe in :FidgetNotifications

i plan to use both and my use case would be:

  • general notifications to nvim-notify via vim.notify()
  • lsp notifications to fidget
@j-hui j-hui added the enhancement New feature or request label Nov 10, 2023
@j-hui j-hui changed the title feature request: capture messages in :FidgetNotifications feat: support notification history Nov 10, 2023
@j-hui
Copy link
Owner

j-hui commented Nov 10, 2023

Certainly! This is actually something I already had in mind, but I didn't want to work on it until I decide on the right mechanism for omitting notifications from history (e.g., to ignore progress notifications, which some may consider spammy).

Also I want to do it as a subcommand system (e.g., something like :Fidget history rather than :FidgetHistory).

Also I want to support using Telescope as a notifications viewer (:

j-hui added a commit that referenced this issue Dec 12, 2023
Low-level answer to #149 (but I still need to some functionality to
actually print out the history for interactive use)
@j-hui j-hui closed this as completed in 921ee3f Dec 19, 2023
@j-hui
Copy link
Owner

j-hui commented Dec 19, 2023

Now, run require("fidget.notification").show_history() to see the history in the echo buffer; or, just use get_history() to get a list of HistoryItems that you can consume or print out yourself. I will create separate issues for the subcommand system and Telescope integration.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants