feat: add safari support #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thank you for opening this! https://github.com/zellyn/kooky is not actively maintained anymore I think, I created a PR on my fork with your commits here j178/kooky#1 (you are still the author 😄 ), I will test and merge it tomorrow. Then we can proceed on this PR. |
|
Okay. Once you merged the PR, I will modify the README. There will require some actions in MacOS Settings. So I think this PR may take another day. |
|
Hi, j178/kooky#1 has been merged, and we can update the |
|
Yeah, I will update it later. Thank you. I will update this PR later. |
|
@j178 I have updated this PR. Need to mention: I only tested this feature at Ventura (Mac OS 13) on M1 Max. |
j178
reviewed
Feb 3, 2023
j178
reviewed
Feb 3, 2023
|
README_zh.md done |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a Draft PR because it requires another dependency to merge a Fix PR.
This PR is going to support safari linked to issue #74.
The
kookyproject got a bug in Ventura and we could not read the correct cookie file. I have created a Fix PR but not been merged yet.But I found that this project is using @j178's fork version of
kooky. I am wondering if you will sync the code from sourcekooky. If you don't sync the code from the source repo, I may need to create the same fix for your fork.Besides, I only test the
leetgo whoamicommand locally. And the README will be modified after the dependency is updated.