return: Fix PowerPC assembly #113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original assembly used suspicious syntax. However, due to the !defined(__OPTIMIZE__) guard this code was rarely built. There nothing to stop the compiler using r0 between the two asm blocks, which may have been the cause of the note mentioning it failed when build with optimisation enabled. Write a single asm statement that places the result in the given location. This builds for powerpc64le and passes tests.
shenki
added a commit
to shenki/buildroot
that referenced
this pull request
May 9, 2022
Fixes the following build failure on powerpc64le: http://autobuild.buildroot.net/results/1f84facd106abdd59be87b9f6e1eb24bcef0a846 Assembler messages: Error: missing operand The code will fail to build on any powerpc platform with optimisation disabled as package contains incorrect syntax behind !defined(__OPTIMIZE__). The patch has been submitted to the project: j256/dmalloc#113 Signed-off-by: Joel Stanley <joel@jms.id.au>
woodsts
pushed a commit
to woodsts/buildroot
that referenced
this pull request
May 13, 2022
Fixes the following build failure on powerpc64le: http://autobuild.buildroot.net/results/1f84facd106abdd59be87b9f6e1eb24bcef0a846 Assembler messages: Error: missing operand The code will fail to build on any powerpc platform with optimisation disabled as package contains incorrect syntax behind !defined(__OPTIMIZE__). The patch has been submitted to the project: j256/dmalloc#113 Signed-off-by: Joel Stanley <joel@jms.id.au> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
colemancda
pushed a commit
to MillerTechnologyPeru/buildroot
that referenced
this pull request
May 23, 2022
Fixes the following build failure on powerpc64le: http://autobuild.buildroot.net/results/1f84facd106abdd59be87b9f6e1eb24bcef0a846 Assembler messages: Error: missing operand The code will fail to build on any powerpc platform with optimisation disabled as package contains incorrect syntax behind !defined(__OPTIMIZE__). The patch has been submitted to the project: j256/dmalloc#113 Signed-off-by: Joel Stanley <joel@jms.id.au> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
buildroot-auto-update
pushed a commit
to buildroot/buildroot
that referenced
this pull request
May 28, 2022
Fixes the following build failure on powerpc64le: http://autobuild.buildroot.net/results/1f84facd106abdd59be87b9f6e1eb24bcef0a846 Assembler messages: Error: missing operand The code will fail to build on any powerpc platform with optimisation disabled as package contains incorrect syntax behind !defined(__OPTIMIZE__). The patch has been submitted to the project: j256/dmalloc#113 Signed-off-by: Joel Stanley <joel@jms.id.au> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> (cherry picked from commit 2712e32) Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original assembly used suspicious syntax. However, due to the
!defined(OPTIMIZE) guard this code was rarely built.
There nothing to stop the compiler using r0 between the two asm blocks,
which may have been the cause of the note mentioning it failed when
build with optimisation enabled.
Write a single asm statement that places the result in the given
location.
This builds for powerpc64le and passes tests.