-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom cache functions #216
Conversation
Cant understand why the build fails. Have no reason to do so, can you see? |
Ok will fix indent issues |
Looks like the build is failing with this error: https://travis-ci.org/j4mie/idiorm/jobs/28039970#L54
|
Got it, thanks for your time helping out. |
Hi Simon, the cache is not automatically deleted on save and this test never runs https://github.com/peter-mw/idiorm/blob/master/test/CacheTest.php#L60 I want to make the cache to be deleted automatically on save. What do you think? |
Well, that would change existing behaviour so that has the potential to On 20 June 2014 15:08, Peter Ivanov notifications@github.com wrote:
Simon Holywell I have also written a book: Functional Programming in PHP |
Added the option and readme. It says the build is still failing, but i don't know why? What i am doing wrong on line 47? I don't see https://github.com/peter-mw/idiorm/blob/master/test/CacheTest.php#L47 |
What is the error message you're getting back? On 20 June 2014 15:58, Peter Ivanov notifications@github.com wrote:
Simon Holywell I have also written a book: Functional Programming in PHP |
Strange one.
It works on my end and tests are passing |
That is from a PHP 5.2 build - anonymous functions weren't supported back On 20 June 2014 16:05, Peter Ivanov notifications@github.com wrote:
Simon Holywell I have also written a book: Functional Programming in PHP |
I think its ready. Can you take a look |
Yeah fixed the spaces :) Thanks for the guidelines, the implementation was not hard at all. Hope this is OK to get merged at some time, so i can base my other work on it. |
Done |
Wait i need to override the |
`table_name` is more important than `connection_name`
Think its OK now. I will try to implement the cache in the real app. Will test properly and update this issue if i find any bugs |
In the config docs
should be
Also, should this be merged into develop first? |
Yes, this will be merged into the develop branch first. I can do this even |
Hi, i can send PR in the |
Merged in commit e7b77ad |
YoHoo! Thanks for the release :) |
As of #212