Rad 2751/specify ad units set targeting for ast (prebid#3805)

* add adUnitCodes as param for setTargetingForAst() * unit tests for setTargetingForAst * refactor * Revert "refactor" This reverts commit 1a89d02. * refactor to add more tests
jacekburys-quantcast · May 15, 2019 · 29d11ce · 29d11ce
1 parent 3b96184
commit 29d11ce
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 1 deletion.
diff --git a/src/targeting.js b/src/targeting.js
@@ -255,7 +255,7 @@ export function newTargeting(auctionManager) {
     let astTargeting = targeting.getAllTargeting(adUnitCodes);
 
     try {
-      targeting.resetPresetTargetingAST();
+      targeting.resetPresetTargetingAST(adUnitCodes);
     } catch (e) {
       utils.logError('unable to reset targeting for AST' + e)
     }

diff --git a/test/spec/unit/core/targeting_spec.js b/test/spec/unit/core/targeting_spec.js
@@ -326,4 +326,44 @@ describe('targeting tests', function () {
       });
     });
   });
+
+  describe('setTargetingForAst', function () {
+    let sandbox,
+      apnTagStub;
+    beforeEach(function() {
+      sandbox = sinon.createSandbox();
+      sandbox.stub(targetingInstance, 'resetPresetTargetingAST');
+      apnTagStub = sandbox.stub(window.apntag, 'setKeywords');
+    });
+    afterEach(function () {
+      sandbox.restore();
+    });
+
+    it('should set single addUnit code', function() {
+      let adUnitCode = 'testdiv-abc-ad-123456-0';
+      sandbox.stub(targetingInstance, 'getAllTargeting').returns({
+        'testdiv1-abc-ad-123456-0': {hb_bidder: 'appnexus'}
+      });
+      targetingInstance.setTargetingForAst(adUnitCode);
+      expect(targetingInstance.getAllTargeting.called).to.equal(true);
+      expect(targetingInstance.resetPresetTargetingAST.called).to.equal(true);
+      expect(apnTagStub.callCount).to.equal(1);
+      expect(apnTagStub.getCall(0).args[0]).to.deep.equal('testdiv1-abc-ad-123456-0');
+      expect(apnTagStub.getCall(0).args[1]).to.deep.equal({HB_BIDDER: 'appnexus'});
+    });
+
+    it('should set array of addUnit codes', function() {
+      let adUnitCodes = ['testdiv1-abc-ad-123456-0', 'testdiv2-abc-ad-123456-0']
+      sandbox.stub(targetingInstance, 'getAllTargeting').returns({
+        'testdiv1-abc-ad-123456-0': {hb_bidder: 'appnexus'},
+        'testdiv2-abc-ad-123456-0': {hb_bidder: 'appnexus'}
+      });
+      targetingInstance.setTargetingForAst(adUnitCodes);
+      expect(targetingInstance.getAllTargeting.called).to.equal(true);
+      expect(targetingInstance.resetPresetTargetingAST.called).to.equal(true);
+      expect(apnTagStub.callCount).to.equal(2);
+      expect(apnTagStub.getCall(1).args[0]).to.deep.equal('testdiv2-abc-ad-123456-0');
+      expect(apnTagStub.getCall(1).args[1]).to.deep.equal({HB_BIDDER: 'appnexus'});
+    });
+  });
 });