Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables the
rustls-tls
feature flag on thereqwest
dependency. This allows it to userustls
in place of theopenssl
dependency, which should allow for further compatibility on different Linux distributions.As far as I can tell,
default-features
must be disabled for this to work. From my testing, it doesn't seem to make a difference (i.e. cause an error) when it comes to building the project.As it stands, the Linux binary for the latest release produces the following error on Ubuntu 22.04:
error while loading shared libraries: libssl.so.1.1: cannot open shared object file: No such file or directory
I suspect this is because the version of Ubuntu the binary was compiled on is different, so it expects a different version of OpenSSL.
This can also be solved by including the
openssl
dependency with thevendored
feature enabled, but it seems like most Rust projects are usingrustls
now (including rbxcloud and aftman).