Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rustls for reqwest #37

Merged
merged 1 commit into from
May 4, 2024
Merged

Conversation

paradoxuum
Copy link
Contributor

@paradoxuum paradoxuum commented May 3, 2024

This change enables the rustls-tls feature flag on the reqwest dependency. This allows it to use rustls in place of the openssl dependency, which should allow for further compatibility on different Linux distributions.

As far as I can tell, default-features must be disabled for this to work. From my testing, it doesn't seem to make a difference (i.e. cause an error) when it comes to building the project.

As it stands, the Linux binary for the latest release produces the following error on Ubuntu 22.04:
error while loading shared libraries: libssl.so.1.1: cannot open shared object file: No such file or directory
I suspect this is because the version of Ubuntu the binary was compiled on is different, so it expects a different version of OpenSSL.

This can also be solved by including the openssl dependency with the vendored feature enabled, but it seems like most Rust projects are using rustls now (including rbxcloud and aftman).

@jackTabsCode
Copy link
Owner

Yeah, this is probably a good idea. Thanks!

@jackTabsCode jackTabsCode merged commit d43b2df into jackTabsCode:main May 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants