Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document toast lifecycle and interactions with DOM #15

Open
fergald opened this issue May 29, 2019 · 0 comments
Open

Document toast lifecycle and interactions with DOM #15

fergald opened this issue May 29, 2019 · 0 comments

Comments

@fergald
Copy link
Collaborator

fergald commented May 29, 2019

With the showToast API, I should be able to do

showToast(...);

and have a toast appear for a time, then disappear and everything gets garbage collected. I do not end up with a sitting in my DOM forever. However

var toast;
...
toast = showToast(...);

should give me an object that I can show/hide over and over. I think this implies that a showToast-created toast should insert/remove itself from the DOM as it's shown/hidden. What about a toast that is naturally in the DOM? It seems like it shouldn't pop in and out of the DOM on show/hide since the DOM may be the only reference to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant