-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify explainer and address some less-complex issues #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this sufficiently addresses #27. It briefly mentions related things when talking about the Notifications API, but given the pattern folks have seen on Android, I think we should have an explicit section (maybe under additional resources / FAQs? I dunno) explaining that proposed toasts are an in-page element and not a system-level thing like notifications or like the old Android toasts API.
Co-Authored-By: Domenic Denicola <d@domenic.me>
Co-Authored-By: Domenic Denicola <d@domenic.me>
Co-Authored-By: Domenic Denicola <d@domenic.me>
Co-Authored-By: fergald <fergald@gmail.com>
…erg/std-toast into spec-feedback-update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nits!
Co-Authored-By: Domenic Denicola <d@domenic.me>
…erg/std-toast into spec-feedback-update
Address Issues: