Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create CODEOWNERS file #12

Merged
merged 5 commits into from
Nov 9, 2021
Merged

Create CODEOWNERS file #12

merged 5 commits into from
Nov 9, 2021

Conversation

jackdevey
Copy link
Owner

Structure the repo in a much better way. All PRs featuring changes to the dirs and files will require approval from the code owner

@jackdevey
Copy link
Owner Author

I did delete the wrong file but it was an unused one anyway so im doing you a favor here :)

russellbanks
russellbanks suggested changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@russellbanks russellbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to manage the dependencies if you'd like :)

@jackdevey
Copy link
Owner Author

Okay sure

russellbanks
russellbanks approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@russellbanks russellbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackdevey jackdevey merged commit 717add7 into main Nov 9, 2021
@jackdevey jackdevey deleted the add-codeowners branch November 9, 2021 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russellbanks russellbanks russellbanks approved these changes

Assignees

@jackdevey jackdevey

@russellbanks russellbanks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackdevey @russellbanks