Skip to content

Commit

Permalink
Update publish-and-deploy to remove automated release creation (jlfwo…
Browse files Browse the repository at this point in the history
…ng#440)

Turns out the `--attach` command was hallucinated by GPT!
  • Loading branch information
jlfwong authored and jackerghan committed Jul 28, 2023
1 parent 6e76e25 commit b90e99f
Showing 1 changed file with 26 additions and 3 deletions.
29 changes: 26 additions & 3 deletions scripts/publish-and-deploy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,32 @@ git push --tags
# Publish to npm
npm publish

# Deploy the website
npm run deploy

# Create a new release on Github
"$script_dir/prepare-zip-file.sh"
gh release create "$tagname" --title "$tagname" --notes "$changelog_update" --attach "dist/release/speedscope-$version.zip"

# Deploy the website
npm run deploy
# Don't double echo the below commands
set +x

echo
echo
echo "Visit https://github.com/jlfwong/speedscope/releases/new to create a new release."
echo
echo "tag: $tagname"
echo "title: $tagname"
echo "attachment: dist/release/speedscope-$version.zip"
echo "$changelog_update"

# NOTE: This part is almost-but-not-quite-automatable using a command like this:
#
# gh release create "$tagname" --title "$tagname" --notes "$changelog_update"
# --attach "dist/release/speedscope-$version.zip"
#
# There are two problems.
#
# 1. The "--attach" flag doesn't exit
# 2. I don't want the changelog notes to include the version and date like they do in CHANGELOG.md
#
# If 1. was solveable, then 2. would be easy to work-around.

0 comments on commit b90e99f

Please sign in to comment.