Skip to content

Commit

Permalink
fix: hide graph feedback tests behind flag (VowpalWabbit#4617)
Browse files Browse the repository at this point in the history
* fix: hide graph feedback tests behind flag

* hid more
  • Loading branch information
bassmang authored Jun 22, 2023
1 parent d47cbc5 commit 453f287
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

#include <vector>

#ifdef VW_FEAT_CB_GRAPH_FEEDBACK
using namespace testing;
constexpr float EXPLICIT_FLOAT_TOL = 0.01f;

Expand Down Expand Up @@ -280,4 +281,5 @@ TEST(cb_fg_label_tests, parse_json_label_bad_graph)
EXPECT_NEAR(sum, 1, EXPLICIT_FLOAT_TOL);

VW::finish_example(*vw, examples);
}
}
#endif
4 changes: 3 additions & 1 deletion vowpalwabbit/core/tests/cb_graph_feedback_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

#include <string>

#ifdef VW_FEAT_CB_GRAPH_FEEDBACK
using namespace testing;
constexpr float EXPLICIT_FLOAT_TOL = 0.01f;

Expand Down Expand Up @@ -663,4 +664,5 @@ TEST(GraphFeedback, CheckUpdateRule500WIterations)
EXPECT_GT(ctr_gf.back(), ctr_egreedy.back());
EXPECT_GT(sim_gf.not_spam_classified_as_not_spam, sim_egreedy.not_spam_classified_as_not_spam);
EXPECT_LT(sim_gf.not_spam_classified_as_spam, sim_egreedy.not_spam_classified_as_spam);
}
}
#endif

0 comments on commit 453f287

Please sign in to comment.