Wire up exemplar to proxystorage (will now return errors instead of

panic) Related to #420
jacksontj · Nov 2, 2021 · b271e7f · b271e7f
1 parent 2d3d054
commit b271e7f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 10 deletions.
diff --git a/cmd/promxy/main.go b/cmd/promxy/main.go
@@ -343,16 +343,17 @@ func main() {
 	scrapeManager := scrape.NewManager(nil, kitlog.With(logger, "component", "scrape manager"), nil)
 
 	webOptions := &web.Options{
-		Registerer:    prometheus.DefaultRegisterer,
-		Gatherer:      prometheus.DefaultGatherer,
-		Context:       ctx,
-		Storage:       proxyStorage,
-		LocalStorage:  ps,
-		QueryEngine:   engine,
-		ScrapeManager: scrapeManager,
-		RuleManager:   ruleManager,
-		Notifier:      notifierManager,
-		LookbackDelta: opts.QueryLookbackDelta,
+		Registerer:      prometheus.DefaultRegisterer,
+		Gatherer:        prometheus.DefaultGatherer,
+		Context:         ctx,
+		Storage:         proxyStorage,
+		LocalStorage:    ps,
+		ExemplarStorage: ps,
+		QueryEngine:     engine,
+		ScrapeManager:   scrapeManager,
+		RuleManager:     ruleManager,
+		Notifier:        notifierManager,
+		LookbackDelta:   opts.QueryLookbackDelta,
 
 		RemoteReadConcurrencyLimit: opts.RemoteReadMaxConcurrency,
 

diff --git a/pkg/proxystorage/proxy.go b/pkg/proxystorage/proxy.go
@@ -182,6 +182,10 @@ func (p *ProxyStorage) ChunkQuerier(ctx context.Context, mint, maxt int64) (stor
 	return nil, errors.New("not implemented")
 }
 
+func (p *ProxyStorage) ExemplarQuerier(ctx context.Context) (storage.ExemplarQuerier, error) {
+	return nil, errors.New("not implemented")
+}
+
 func (p *ProxyStorage) WALReplayStatus() (tsdb.WALReplayStatus, error) {
 	return tsdb.WALReplayStatus{}, errors.New("not implemented")
 }