Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(layout): restore footer to the proper position #1470

Merged
merged 2 commits into from
Oct 1, 2024
Merged

fix(layout): restore footer to the proper position #1470

merged 2 commits into from
Oct 1, 2024

Conversation

saberzero1
Copy link
Collaborator

@saberzero1 saberzero1 commented Oct 1, 2024 •
edited
Loading

  • Restores the footer position to the bottom, putting the right sidebar between the center and footer on mobile and tablet layouts.
  • Renamed the grid-areas to more accurately reflect their usage and reduce confusion with similar CSS classes.
  • Table of Content scrollbar alignment.

Before:

Mobile

Screenshot from 2024-10-01 14-56-16

Tablet

Screenshot from 2024-10-01 14-56-29

After:

Mobile

Screenshot from 2024-10-01 14-57-07

Tablet

Screenshot from 2024-10-01 14-57-21

@jackyzha0 jackyzha0 merged commit b0c079f into jackyzha0:v4 Oct 1, 2024
4 checks passed
@saberzero1 saberzero1 deleted the grid-triage-part-4 branch October 1, 2024 16:28
@saberzero1 saberzero1 mentioned this pull request Oct 1, 2024
Merged
7 tasks
ChenghaoMou pushed a commit to ChenghaoMou/quartz that referenced this pull request Oct 5, 2024
@saberzero1 @ChenghaoMou
fix(layout): restore footer to the proper position (jackyzha0#1470)
c395f1c 
* fix(layout): restore footer to the proper position

* align ToC scrollbar properly on short headers
parkisutama pushed a commit to parkisutama/quartz that referenced this pull request Oct 6, 2024
@saberzero1 @parkisutama
fix(layout): restore footer to the proper position (jackyzha0#1470)
e227c5d 
* fix(layout): restore footer to the proper position

* align ToC scrollbar properly on short headers
DronHazra pushed a commit to DronHazra/quartz that referenced this pull request Oct 27, 2024
@saberzero1 @DronHazra
fix(layout): restore footer to the proper position (jackyzha0#1470)
f9444cd 
* fix(layout): restore footer to the proper position

* align ToC scrollbar properly on short headers
DronHazra pushed a commit to DronHazra/quartz that referenced this pull request Oct 28, 2024
@saberzero1 @DronHazra
fix(layout): restore footer to the proper position (jackyzha0#1470)
7cb96ef 
* fix(layout): restore footer to the proper position

* align ToC scrollbar properly on short headers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackyzha0 jackyzha0 jackyzha0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saberzero1 @jackyzha0