Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Date): Account for local timezone offset #1643

Draft
wants to merge 2 commits into
base: v4
Choose a base branch
from

Conversation

saberzero1
Copy link
Collaborator

@saberzero1 saberzero1 commented Dec 8, 2024

Dates sometimes are a day behind or ahead if the user is in a non-UTC timezone. This PR aims to fix that.

TODO

  • verify with several time zones
  • optionally allow users to configure if their build server has a different time zone than their notes(?)

@saberzero1 saberzero1 requested a review from Copilot December 8, 2024 22:37

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (1)

quartz/components/Date.tsx:30

  • The datetime attribute should be in ISO 8601 format. Using formatDate(date) might not produce a valid datetime string. Consider using date.toISOString() for the datetime attribute.
return <time datetime={formatDate(date)}>{formatDate(date, locale)}</time>
@saberzero1 saberzero1 requested a review from Copilot December 9, 2024 00:10

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant