Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to change healthcheck url #45

Merged
merged 1 commit into from
Sep 22, 2020

Conversation

kdauzickas
Copy link
Contributor

@kdauzickas kdauzickas commented Jul 14, 2020

Health check urls aren't really standardized - many use healthz but just as many use completely custom endpoints.
Having a command line option to change this url adds some flexibility when deploying this application without provided helm chart.

@jacobbednarz
Copy link
Owner

Thanks for the contribution @kdauzickas! Would you be able to update your Pull Request description with a little context about this change? On the surface, it looks fine however I'd like to ensure I'm fully understanding your issue and the intended fix.

With this change, we'll also need to look at updating the README command line options section as well to keep these documented.

@jacobbednarz
Copy link
Owner

Appreciate the update here @kdauzickas and apologies on the delay. As you force pushed this, I didn't get a notification the change was ready. This looks fine to me! Thanks again 🍰

@jacobbednarz jacobbednarz merged commit 5e5a12f into jacobbednarz:master Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants