Add source-file and associated column-number and line-number. #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the PR. we need to add some test coverage for this change. there should be enough prior art for you to work from but if not, let me know and I'll put an example together for you. |
Fix build command in README and change `-` to `_` for consistency with Dockerfile. Fixes jacobbednarz#94.
chennin
force-pushed
the
chennin/add_source_file
branch
from
441496a
to
d7428ee
Compare
|
Added a test! |
|
thanks! |
jacobbednarz
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add source-file and associated column-number and line-number.
Also fix build command in README and change
-to_for consistency with Dockerfile.Fixes #94.
I don't actually program in go, but I can copy and paste and change text. It passes
go testand in a live test comes out in Grafana as follows: