Ignore choices if option not supplied

jacobdeichert · Oct 13, 2024 · 1429d65 · 1429d65
1 parent 52c75e8
commit 1429d65
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 1 deletion.
diff --git a/mask/src/main.rs b/mask/src/main.rs
@@ -198,7 +198,7 @@ fn get_command_options(mut cmd: Command, matches: &ArgMatches) -> Command {
                 .unwrap()
                 .to_string();
 
-            if !flag.choices.is_empty() {
+            if !flag.choices.is_empty() && raw_value != "" {
                 if !flag.choices.iter().any(|choice| choice == &raw_value) {
                     eprintln!(
                         "{} flag `{}` expects one of {:?}",

diff --git a/mask/tests/arguments_and_flags_test.rs b/mask/tests/arguments_and_flags_test.rs
@@ -212,6 +212,38 @@ Write-Output "Value: $in"
             .success();
     }
 
+    #[test]
+    fn ignores_the_option_if_not_supplied() {
+        let (_temp, maskfile_path) = common::maskfile(
+            r#"
+## color
+
+**OPTIONS**
+* val
+    * flags: --val
+    * type: string
+    * choices: RED, BLUE, GREEN
+
+```bash
+echo "Value: $val;"
+```
+
+```powershell
+param (
+    $in = $env:val
+)
+Write-Output "Value: $in;"
+```
+"#,
+        );
+
+        common::run_mask(&maskfile_path)
+            .cli("color")
+            .assert()
+            .stdout(contains("Value: ;"))
+            .success();
+    }
+
     #[test]
     fn out_of_choices() {
         let (_temp, maskfile_path) = common::maskfile(