Skip to content

Commit

Permalink
Image publishers use SensorDataQoSProfile (ros-simulation#1031)
Browse files Browse the repository at this point in the history
All other sensor publishers were updated previously to use the same profile (ros-simulation#926).
I'm not sure if the image publishers were overlooked or the image_transport API didn't
support setting the QoS profile at the time.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
  • Loading branch information
jacobperron committed Jun 17, 2020
1 parent c40be68 commit e6ddca1
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions gazebo_plugins/src/gazebo_ros_camera.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ void GazeboRosCamera::Load(gazebo::sensors::SensorPtr _sensor, sdf::ElementPtr _
image_transport::create_publisher(
impl_->ros_node_.get(),
camera_topic,
qos.get_publisher_qos(camera_topic).get_rmw_qos_profile()));
qos.get_publisher_qos(camera_topic, rclcpp::SensorDataQos()).get_rmw_qos_profile()));

// TODO(louise) Uncomment this once image_transport::Publisher has a function to return the
// full topic.
Expand All @@ -208,7 +208,8 @@ void GazeboRosCamera::Load(gazebo::sensors::SensorPtr _sensor, sdf::ElementPtr _
impl_->image_pub_.push_back(
image_transport::create_publisher(
impl_->ros_node_.get(),
camera_topic, qos.get_publisher_qos(camera_topic).get_rmw_qos_profile()));
camera_topic,
qos.get_publisher_qos(camera_topic, rclcpp::SensorDataQoS()).get_rmw_qos_profile()));

// RCLCPP_INFO(
// impl_->ros_node_->get_logger(), "Publishing %s camera images to [%s]",
Expand All @@ -235,7 +236,7 @@ void GazeboRosCamera::Load(gazebo::sensors::SensorPtr _sensor, sdf::ElementPtr _
impl_->depth_image_pub_ = image_transport::create_publisher(
impl_->ros_node_.get(),
depth_topic,
qos.get_publisher_qos(depth_topic).get_rmw_qos_profile());
qos.get_publisher_qos(depth_topic, rclcpp::SensorDataQoS()).get_rmw_qos_profile());

// RCLCPP_INFO(impl_->ros_node_->get_logger(), "Publishing depth images to [%s]",
// impl_->depth_image_pub_.getTopic().c_str());
Expand Down

0 comments on commit e6ddca1

Please sign in to comment.