Allow filesystems to set atomic_o_trunc flag #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @stapelberg, I'd appreciate your review on this change when you get a chance. I tested the new version of this library with our fuse filesystem and the atomic_o_trunc flag worked as expected. I also added some unit tests. Thanks, Scott |
stapelberg
requested changes
Oct 23, 2024
stapelberg
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the atomic_o_trunc flag during the fuse init protocol.
When this flag is enabled, application calls to
openwith the O_TRUNC flag will cause a FUSE OpenFile op with the O_TRUNC flag set. In comparison, the default behavior is an OpenFile op without O_TRUNC, followed by a SetInodeAttributes op with the target size set to 0.Ref: torvalds/linux@6ff958e