Fix bug in routine where request body is deleted. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repair a bug in the self._make_auth() routine where the OAuth1 client is generated before a request body is available. This causes all SuiteQL queries to fail, along with any other functions that require a request body. Resolve by storing the connection details in the class and calling that method again when we detect a post body.
|
Thank you for your contribution @mmangione. I will go ahead and merge this, and then push a commit that adds back the I haven't found any sources that verify this but it seems that release 2021.1 is now requiring that the body to be part of the signing. (All body sending requests seem to fail, not only SuiteQL). |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repair a bug in the self._make_auth() routine where the OAuth1 client is generated before a request body is available. This causes all SuiteQL queries to fail, along with any other functions that require a request body. Resolve by storing the connection details in the class and calling that method again when we detect a post body.