Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to Java 21 #226

Closed
wants to merge 1 commit into from
Closed

Conversation

gschlueter-jaconi
Copy link
Contributor

@gschlueter-jaconi gschlueter-jaconi commented Nov 26, 2023

Pull request checklist

Pull request structure

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your main!
  • Make sure you are making a pull request against the main branch (left side). Also you should start your branch off our main.
  • Check the commits message styles matches our requested structure.

Implementation checks

  • Tests for the changes have been added.
  • Docs have been reviewed and added / updated if needed.
  • Tests (gradle clean check) have passed locally any fixes were made for failures.
  • GitHub checks all pass (GH Actions, Sonar, Codecov).

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL:

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information


❤️ Thank you!

Copy link

codecov bot commented Nov 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.21%. Comparing base (f146a84) to head (c384f4f).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #226   +/-   ##
=========================================
  Coverage     86.21%   86.21%           
  Complexity      123      123           
=========================================
  Files            27       27           
  Lines           312      312           
  Branches         31       31           
=========================================
  Hits            269      269           
  Misses           27       27           
  Partials         16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

build.gradle.kts Outdated Show resolved Hide resolved
@@ -1,27 +0,0 @@
FROM ghcr.io/graalvm/native-image:ol9-java17-22.3.3 AS builder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some new support for native images in Spring Boot 3.2.x, or why don't we need this anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly, no. Since there is no such image yet for Java 21, the only easy way to produce a native image is to use buildpacks. We can think about pushing non-native ARM images though.

server:
port: 8081
port: 8080
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we drop this entirely? Should be the default.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jnodorp-jaconi jnodorp-jaconi changed the title feat: upgrade to Spring Boot 3.2 and Java 21 feat: upgrade to Java 21 Feb 28, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jnodorp-jaconi
Copy link
Member

Closing in favor of #255

@jnodorp-jaconi jnodorp-jaconi deleted the feature/springBoot32 branch February 28, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants