-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to Java 21 #226
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
=========================================
Coverage 86.21% 86.21%
Complexity 123 123
=========================================
Files 27 27
Lines 312 312
Branches 31 31
=========================================
Hits 269 269
Misses 27 27
Partials 16 16 ☔ View full report in Codecov by Sentry. |
2552ed8
to
a850871
Compare
a850871
to
3b57d5f
Compare
@@ -1,27 +0,0 @@ | |||
FROM ghcr.io/graalvm/native-image:ol9-java17-22.3.3 AS builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there some new support for native images in Spring Boot 3.2.x, or why don't we need this anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly, no. Since there is no such image yet for Java 21, the only easy way to produce a native image is to use buildpacks. We can think about pushing non-native ARM images though.
server: | ||
port: 8081 | ||
port: 8080 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we drop this entirely? Should be the default.
3b57d5f
to
b2cb480
Compare
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
b2cb480
to
c384f4f
Compare
Quality Gate passedIssues Measures |
Closing in favor of #255 |
Pull request checklist
Pull request structure
Implementation checks
gradle clean check
) have passed locally any fixes were made for failures.Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL:
What is the new behavior?
Does this introduce a breaking change?
Other information
❤️ Thank you!