refactor: fix caching issue when aggregate is not found

jacqueskang · Feb 15, 2020 · 1a8c23b · 1a8c23b
1 parent 3b6f9e5
commit 1a8c23b
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/src/JKang.EventSourcing.Persistence.Caching/CachedAggregateRepository.cs b/src/JKang.EventSourcing.Persistence.Caching/CachedAggregateRepository.cs
@@ -45,17 +45,24 @@ protected override async Task<TAggregate> FindAggregateAsync(
             int version = -1,
             CancellationToken cancellationToken = default)
         {
-            string key = GetCacheKey(id, version);
-            string serialized = await _cache.GetStringAsync(key, cancellationToken).ConfigureAwait(false);
-            if (!string.IsNullOrEmpty(serialized))
+            try
             {
-                return DeserializeAggregate(serialized);
+                string key = GetCacheKey(id, version);
+                string serialized = await _cache.GetStringAsync(key, cancellationToken).ConfigureAwait(false);
+                if (!string.IsNullOrEmpty(serialized))
+                {
+                    return DeserializeAggregate(serialized);
+                }
             }
+            catch { }
 
             TAggregate aggregate = await base.FindAggregateAsync(id, ignoreSnapshot, version, cancellationToken)
                 .ConfigureAwait(false);
 
-            await CacheAsync(aggregate, version, cancellationToken).ConfigureAwait(false);
+            if (aggregate != null)
+            {
+                await CacheAsync(aggregate, version, cancellationToken).ConfigureAwait(false);
+            }
 
             return aggregate;
         }