Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out of the box JWT authentication using satellizer (Login & Registration) #202

Closed
14 tasks done
jadjoubran opened this issue Mar 13, 2016 · 18 comments
Closed
14 tasks done

Comments

@jadjoubran
Copy link
Owner

  • Setup satellizer
  • Configure satellizer to work with login API (sane defaults for this starter)
  • handle errors using ToastService
  • Login form using Angular Material
  • Register form using Angular Material
  • integration tests for AuthController
  • AuthController
  • Login functionality using satellizer
  • Register functionality using satellizer
  • fix expecting a token issue
  • [Breaking] update API service to use new token
  • test with sample protected route
  • Design fixes? cc/ @nicolesaidy
  • Demo: only local?
@shiruken1
Copy link
Contributor

Let me know if I should upgrade my previous PR to 5.2 and make a new one from that, along with the Material UI for the front-end. I could pull in everything on your checklist, except for the Restangular interceptor.

All the best!

@jadjoubran
Copy link
Owner Author

Hi @shiruken1
Thank you so much for your help!

I have a branch I've been working on.. it should be done by this weekend I'll share the result soon 😄

@chojuanillo
Copy link

I look forward , as I have to implement my project . a million thanks

@yunus89
Copy link

yunus89 commented Mar 19, 2016

Hi @jadjoubran ,

I really need Satellizer integrated into this starter. Could you please estimate how much time will take you to complete the above tasks?

@jadjoubran
Copy link
Owner Author

Hi @yunus89
I'm finally back home from a long trip 😄
It will be ready by the end of this week for sure

But keep in mind that you can also follow the installation guide provided by satellizer..I'll just try to polish some things to make it more accessible for everyone
Cheers

@ChadTaljaardt
Copy link

Thanks for this @jadjoubran It will be a great addition 😄

jadjoubran added a commit that referenced this issue Mar 22, 2016
jadjoubran added a commit that referenced this issue Mar 22, 2016
@jadjoubran
Copy link
Owner Author

Halfway through 😄

@shiruken1
Copy link
Contributor

I know it's been forever, but I finally have the UI for this!

It's pretty nifty, is responsively designed, and includes landing page (which I can leave out), login with email/password, a dropdown to select a social network (with template interactivity and corresponding Angular functionality), and registration.

Do you still want it? How should I deliver it? Let me know!

@franklupo
Copy link

Great addition

@jadjoubran
Copy link
Owner Author

@shiruken1 Thanks for this! But don't worry the feature is almost over 😄
I am not doing social network login by default since this is an easy task, people would just need to follow satellizer's docs.. and not everyone would need it
I'll push the remaining fixes in the coming few days 😄

@jadjoubran
Copy link
Owner Author

This is done 😄
I still need to design the 2 pages with @nicolesaidy
I'd love to get your feedback if anyone feels like testing it

If all goes well, I'll update the docs & record a screencast

Meanwhile, here are the steps to test:

  • install latest unstable version
  • php artisan migrate
  • navigate to /#/register and create an account
  • navigate to /#/login and login
    Mainly there are 2 pages, login & register and 2 components: login-form and register-form
    You can also take a look at the satellizer code in the components
    satellizer configuration is available in angular/config/satellizer.config.js

jadjoubran added a commit that referenced this issue Mar 25, 2016
@jadjoubran
Copy link
Owner Author

Thanks @nicolesaidy for the design fixes 😄

login screenshot
register screenshot

@kujtimiihoxha
Copy link
Contributor

@jadjoubran I think #129 should be part of this implementation, what do you think ?

@jadjoubran
Copy link
Owner Author

Yes it will 😄 I've already updated the milestone to 3.2

@kujtimiihoxha
Copy link
Contributor

@jadjoubran I think that the register form should have a confirm password field what do you think ?

@jadjoubran
Copy link
Owner Author

@kujtimiihoxha I've seen a lot of startups omit this field.. For the simple reason that in case a user writes a wrong one (which rarely happens, he can just reset his password)
However it should be very straightforward if anyone wants it for his own project

@shiruken1
Copy link
Contributor

Yup. The less fields the better.

We're actually omitting the password field entirely, and make them change
the password we generated for them, as soon as they finish registration.
On Mar 26, 2016 7:38 AM, "Jad Joubran" notifications@github.com wrote:

@kujtimiihoxha https://github.com/kujtimiihoxha I've seen a lot of
startups omit this field.. For the simple reason that in case a user writes
a wrong one (which rarely happens, he can just reset his password)
However it should be very straightforward if anyone wants it for his own
project


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#202 (comment)

@jadjoubran
Copy link
Owner Author

Documentation & screencast moved to trello board (when 3.2 becomes available)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants