Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method for groups.setAnnouncement #149

Merged
merged 3 commits into from
Nov 17, 2021

Conversation

rocketchat_API/APISections/groups.py Outdated Show resolved Hide resolved
rocketchat_API/APISections/groups.py Outdated Show resolved Hide resolved
@BenjaminBoehm
Copy link
Author

BenjaminBoehm commented Nov 17, 2021

Then we should consider changing the channels_set_announcement argument as well to keep API naming:

def channels_set_announcement(self, room_id, announce, **kwargs):

Reference: https://developer.rocket.chat/reference/api/rest-api/endpoints/team-collaboration-endpoints/channels-endpoints/setannouncement

@jadolg
Copy link
Owner

jadolg commented Nov 17, 2021

Then we should consider changing the channels_set_announcement argument as well to keep API naming:

def channels_set_announcement(self, room_id, announce, **kwargs):

Reference: https://developer.rocket.chat/reference/api/rest-api/endpoints/team-collaboration-endpoints/channels-endpoints/setannouncement

nice catch :)
It's fixed in master already.

@jadolg jadolg merged commit 8be9902 into jadolg:master Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants