replace exports with module.exports #166
Conversation
| readEeproms: readEeproms, | ||
| readPlatform: readPlatform, | ||
|
|
There was a problem hiding this comment.
Sorry i did not notice this , i copied the exports for the hw_X.js as the exports are same for these files, that was why the mistake was repeated, i will be more careful in future.
| readEeproms: readEeproms, | ||
| readPlatform: readPlatform, | ||
|
|
There was a problem hiding this comment.
Another one. Not sure why the blank lines.
| readEeproms: readEeproms, | ||
| readPlatform: readPlatform, | ||
|
|
There was a problem hiding this comment.
Again, extraneous. The repetition makes me wonder if the definition of what gets exported from these hw_X.js files should be common as they satisfy an internal API.
| readEeproms: readEeproms, | ||
| readPlatform: readPlatform, | ||
|
|
| @@ -667,9 +665,10 @@ process.nextTick(run); | |||
| // Global variable assignments | |||
| // This section is broken out because it will eventually be deprecated | |||
| function setGlobals() { | |||
There was a problem hiding this comment.
Given the way things are done, this could probably be f.setGlobals = function() {.
There was a problem hiding this comment.
Yes, that would be the better way , i will make the correction.
| rcMotor: rcMotor, | ||
| rcEncoder: rcEncoder | ||
|
|
There was a problem hiding this comment.
Another blank line. Inconsistent on ending with commas or not.
Style fixes as suggested in pull #166
I have made the suggested changes. can you please review it.I did verify the exported objects before and after the change was made.
Issue #82