Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch to handle debugfs not mounted #169

Merged
merged 1 commit into from
May 16, 2018
Merged

Conversation

vaishnavachath
Copy link
Contributor

I have tried to add a patch using shelljs to handle the case when debugfs is not mounted(Issue #61 [still exists]).The issue is solved after adding the patch and I also did note the run-time before and after the change(for this example script: http://beagleboard.org/Support/BoneScript/getPinMode/), the results are :

before making the change :

real 0m8.573s
user 0m7.748s
sys 0m0.564s

after making the change(when debugfs already mounted) :

real 0m8.783s
user 0m8.068s
sys 0m0.516s

after making the change(when debugfs not mounted) :

real 0m10.074s
user 0m9.192s
sys 0m0.680s

@coveralls
Copy link

coveralls commented May 16, 2018

Coverage Status

Coverage remained the same at 35.912% when pulling e03ad17 on vaishnav98:master into 2148f35 on jadonk:master.

Copy link
Owner

@jadonk jadonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use shelljs vs just doing an exec? Probably need to use it consistently if goong to use it. How does it compare?

@jadonk jadonk merged commit a7282d9 into jadonk:master May 16, 2018
@vaishnavachath
Copy link
Contributor Author

I just found that using shelljs was actually a slower alternative than doing .exec() , did not know about it earlier will fix it while submitting another patch.

@vaishnavachath
Copy link
Contributor Author

beagleboard#16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants