Skip to content

Commit

Permalink
[SystemZ] Bugfix for backchain with packed-stack
Browse files Browse the repository at this point in the history
The incoming back chain slot was implicitly allocated whenever a GPR was
saved in SystemZFrameLowering::getRegSpillOffset(), but in cases where no
GPRs were saved/restored this did not take effect.

Review: Ulrich Weigand

Differential Revision: https://reviews.llvm.org/D75367
  • Loading branch information
JonPsson committed Mar 3, 2020
1 parent c68d35d commit 2376257
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 2 deletions.
5 changes: 3 additions & 2 deletions llvm/lib/Target/SystemZ/SystemZFrameLowering.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -315,9 +315,10 @@ void SystemZFrameLowering::
processFunctionBeforeFrameFinalized(MachineFunction &MF,
RegScavenger *RS) const {
MachineFrameInfo &MFFrame = MF.getFrameInfo();
bool BackChain = MF.getFunction().hasFnAttribute("backchain");

if (!usePackedStack(MF))
// Always create the full incoming register save area.
if (!usePackedStack(MF) || BackChain)
// Create the incoming register save area.
getOrCreateFramePointerSaveIndex(MF);

// Get the size of our stack frame to be allocated ...
Expand Down
24 changes: 24 additions & 0 deletions llvm/test/CodeGen/SystemZ/frame-25.ll
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
; RUN: llc < %s -mtriple=s390x-linux-gnu | FileCheck %s
;
; Test that space is allocated for the incoming back chain also in cases
; where no GPRs are saved / restored.

define void @fun0() #0 {
; CHECK-LABEL: fun0:
; CHECK: lgr %r1, %r15
; CHECK-NEXT: aghi %r15, -24
; CHECK-NEXT: stg %r1, 152(%r15)
; CHECK-NEXT: #APP
; CHECK-NEXT: stcke 160(%r15)
; CHECK-NEXT: #NO_APP
; CHECK-NEXT: aghi %r15, 24
; CHECK-NEXT: br %r14

entry:
%b = alloca [16 x i8], align 1
%0 = getelementptr inbounds [16 x i8], [16 x i8]* %b, i64 0, i64 0
call void asm "stcke $0", "=*Q"([16 x i8]* nonnull %b) #2
ret void
}

attributes #0 = { nounwind "packed-stack" "backchain" "use-soft-float"="true" }

0 comments on commit 2376257

Please sign in to comment.