Merged main:99562332e3de into amd-gfx:23e52d67d639

Local branch amd-gfx 23e52d6 Merged main:c1d6de41a9d9 into amd-gfx:27bfa6aeef61
Remote branch main 9956233 [lldb] [test] Update test status for NetBSD

lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py

@@ -195,10 +195,6 @@ def _init_llgs_test(self):
             # Remove if it's there.
             self.debug_monitor_exe = re.sub(r' \(deleted\)$', '', exe)
         else:
-            # TODO: enable this
-            if platform.system() == 'Windows':
-                reverse_connect = False
-
             self.debug_monitor_exe = get_lldb_server_exe()
             if not self.debug_monitor_exe:
                 self.skipTest("lldb-server exe not found")

lldb/test/API/api/multiple-targets/TestMultipleTargets.py

@@ -21,6 +21,7 @@ class TestMultipleTargets(TestBase):
     @expectedFailureAll(
         oslist=["windows"],
         bugnumber="llvm.org/pr20282")
+    @expectedFlakeyNetBSD
     def test_multiple_targets(self):
         env = {self.dylibPath: self.getLLDBLibraryEnvVal()}
 

lldb/test/API/commands/expression/call-restarts/TestCallThatRestarts.py

@@ -25,7 +25,7 @@ def setUp(self):
     @skipIfDarwin  # llvm.org/pr19246: intermittent failure
     @skipIfWindows  # Test relies on signals, unsupported on Windows
     @expectedFlakeyAndroid(bugnumber="llvm.org/pr19246")
-    @expectedFailureNetBSD
+    @expectedFlakeyNetBSD
     def test(self):
         """Test calling function that hits a signal and restarts."""
         self.build()

lldb/test/API/commands/expression/ir-interpreter/TestIRInterpreter.py

@@ -44,7 +44,6 @@ def build_and_run(self):
     @expectedFailureAll(
         oslist=['windows'],
         bugnumber="http://llvm.org/pr21765")
-    @expectedFailureNetBSD
     def test_ir_interpreter(self):
         self.build_and_run()
 

lldb/test/API/commands/expression/radar_9531204/TestPrintfAfterUp.py

@@ -15,7 +15,6 @@ class Radar9531204TestCase(TestBase):
     mydir = TestBase.compute_mydir(__file__)
 
     # rdar://problem/9531204
-    @expectedFailureNetBSD
     def test_expr_commands(self):
         """The evaluating printf(...) after break stop and then up a stack frame."""
         self.build()

lldb/test/API/commands/expression/save_jit_objects/TestSaveJITObjects.py

@@ -24,7 +24,6 @@ def cleanJITFiles(self):
         return
 
     @expectedFailureAll(oslist=["windows"])
-    @expectedFailureNetBSD
     def test_save_jit_objects(self):
         self.build()
         os.chdir(self.getBuildDir())

lldb/test/API/commands/expression/test/TestExprs.py

@@ -177,7 +177,6 @@ def test_evaluate_expression_python(self):
     # rdar://problem/8686536
     # CommandInterpreter::HandleCommand is stripping \'s from input for
     # WantsRawCommand commands
-    @expectedFailureNetBSD
     def test_expr_commands_can_handle_quotes(self):
         """Throw some expression commands with quotes at lldb."""
         self.build()

lldb/test/API/commands/gui/viewlarge/TestGuiViewLarge.py

@@ -16,6 +16,7 @@ class GuiViewLargeCommandTest(PExpectTest):
     @skipIfAsan
     @skipIfCursesSupportMissing
     @skipIfRemote # "run" command will not work correctly for remote debug
+    @expectedFailureNetBSD
     def test_gui(self):
         self.build()
 

lldb/test/API/commands/process/attach/TestProcessAttach.py

@@ -84,6 +84,7 @@ def test_attach_to_process_by_name(self):
         process = target.GetProcess()
         self.assertTrue(process, PROCESS_IS_VALID)
 
+    @expectedFailureNetBSD
     def test_attach_to_process_by_id_correct_executable_offset(self):
         """
         Test that after attaching to a process the executable offset

lldb/test/API/functionalities/breakpoint/cpp_exception/TestCPPExceptionBreakpoint.py

@@ -17,15 +17,13 @@ class TestCPPExceptionBreakpoint (TestBase):
 
     @add_test_categories(['pyapi'])
     @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24538")
-    @expectedFailureNetBSD
     def test_cpp_exception_breakpoint(self):
         """Test setting and hitting the C++ exception breakpoint."""
         self.build()
         self.do_cpp_exception_bkpt()
 
     @add_test_categories(['pyapi'])
     @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24538")
-    @expectedFailureNetBSD
     def test_dummy_target_cpp_exception_breakpoint(self):
         """Test setting and hitting the C++ exception breakpoint from dummy target."""
         self.build()

lldb/test/API/functionalities/breakpoint/global_constructor/TestBreakpointInGlobalConstructor.py

@@ -15,7 +15,6 @@ class TestBreakpointInGlobalConstructors(TestBase):
     mydir = TestBase.compute_mydir(__file__)
     NO_DEBUG_INFO_TESTCASE = True
 
-    @expectedFailureNetBSD
     def test(self):
         self.build()
         self.line_foo = line_number('foo.cpp', '// !BR_foo')

lldb/test/API/functionalities/completion/TestCompletion.py

@@ -291,6 +291,7 @@ def test_help_watchpoint_s(self):
         """Test that 'help watchpoint s' completes to 'help watchpoint set '."""
         self.complete_from_to('help watchpoint s', 'help watchpoint set ')
 
+    @expectedFailureNetBSD
     def test_common_complete_watchpoint_ids(self):
         subcommands = ['enable', 'disable', 'delete', 'modify', 'ignore']
 

lldb/test/API/functionalities/dlopen_other_executable/TestDlopenOtherExecutable.py

@@ -14,6 +14,7 @@ class TestCase(TestBase):
     @skipIfLinux
     # freebsd's dlopen ditto
     @expectedFailureAll(oslist=["freebsd"])
+    @expectedFailureNetBSD
     @no_debug_info_test
     def test(self):
         self.build()

lldb/test/API/functionalities/inferior-assert/TestInferiorAssert.py

@@ -22,7 +22,6 @@ class AssertingInferiorTestCase(TestBase):
         archs=["arm"],
         bugnumber="llvm.org/pr25338")
     @expectedFailureAll(bugnumber="llvm.org/pr26592", triple='^mips')
-    @expectedFailureNetBSD
     def test_inferior_asserting(self):
         """Test that lldb reliably catches the inferior asserting (command)."""
         self.build()
@@ -52,7 +51,6 @@ def test_inferior_asserting_register(self):
         triple=no_match(".*-android"),
         bugnumber="llvm.org/pr25338")
     @expectedFailureAll(bugnumber="llvm.org/pr26592", triple='^mips')
-    @expectedFailureNetBSD
     def test_inferior_asserting_disassemble(self):
         """Test that lldb reliably disassembles frames after asserting (command)."""
         self.build()
@@ -76,7 +74,6 @@ def test_inferior_asserting_python(self):
         triple=no_match(".*-android"),
         bugnumber="llvm.org/pr25338")
     @expectedFailureAll(bugnumber="llvm.org/pr26592", triple='^mips')
-    @expectedFailureNetBSD
     def test_inferior_asserting_expr(self):
         """Test that the lldb expression interpreter can read from the inferior after asserting (command)."""
         self.build()
@@ -91,7 +88,6 @@ def test_inferior_asserting_expr(self):
         triple=no_match(".*-android"),
         bugnumber="llvm.org/pr25338")
     @expectedFailureAll(bugnumber="llvm.org/pr26592", triple='^mips')
-    @expectedFailureNetBSD
     def test_inferior_asserting_step(self):
         """Test that lldb functions correctly after stepping through a call to assert()."""
         self.build()

lldb/test/API/functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferiorStep.py

@@ -20,6 +20,7 @@ def test_recursive_inferior_crashing_step(self):
 
     @skipIfTargetAndroid()  # debuggerd interferes with this test on Android
     @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778")
+    @expectedFailureNetBSD
     def test_recursive_inferior_crashing_step_after_break(self):
         """Test that lldb functions correctly after stepping through a crash."""
         self.build()

lldb/test/API/functionalities/thread/concurrent_events/TestConcurrentBreakpointDelayBreakpointOneSignal.py

@@ -13,7 +13,6 @@ class ConcurrentBreakpointDelayBreakpointOneSignal(ConcurrentEventsBase):
 
     # Atomic sequences are not supported yet for MIPS in LLDB.
     @skipIf(triple='^mips')
-    @expectedFailureNetBSD
     def test(self):
         """Test two threads that trigger a breakpoint (one with a 1 second delay) and one signal thread. """
         self.build(dictionary=self.getBuildFlags())

lldb/test/API/functionalities/thread/concurrent_events/TestConcurrentSignalDelayBreak.py

@@ -13,7 +13,7 @@ class ConcurrentSignalDelayBreak(ConcurrentEventsBase):
 
     # Atomic sequences are not supported yet for MIPS in LLDB.
     @skipIf(triple='^mips')
-    @expectedFailureNetBSD
+    @expectedFlakeyNetBSD
     def test(self):
         """Test signal and a (1 second delay) breakpoint in multiple threads."""
         self.build(dictionary=self.getBuildFlags())

lldb/test/API/functionalities/thread/concurrent_events/TestConcurrentTwoBreakpointsOneDelaySignal.py

@@ -13,7 +13,7 @@ class ConcurrentTwoBreakpointsOneDelaySignal(ConcurrentEventsBase):
 
     # Atomic sequences are not supported yet for MIPS in LLDB.
     @skipIf(triple='^mips')
-    @expectedFailureNetBSD
+    @expectedFlakeyNetBSD
     def test(self):
         """Test two threads that trigger a breakpoint and one (1 second delay) signal thread. """
         self.build(dictionary=self.getBuildFlags())

lldb/test/API/functionalities/thread/concurrent_events/TestConcurrentTwoBreakpointsOneSignal.py

@@ -13,7 +13,7 @@ class ConcurrentTwoBreakpointsOneSignal(ConcurrentEventsBase):
 
     # Atomic sequences are not supported yet for MIPS in LLDB.
     @skipIf(triple='^mips')
-    @expectedFailureNetBSD
+    @expectedFlakeyNetBSD
     def test(self):
         """Test two threads that trigger a breakpoint and one signal thread. """
         self.build(dictionary=self.getBuildFlags())

lldb/test/API/functionalities/thread/exit_during_expression/TestExitDuringExpression.py

@@ -16,12 +16,14 @@ class TestExitDuringExpression(TestBase):
 
     @skipIfWindows
     @expectedFailureAll(oslist=["freebsd"], bugnumber="llvm.org/pr48414")
+    @expectedFailureNetBSD
     def test_exit_before_one_thread_unwind(self):
         """Test the case where we exit within the one thread timeout"""
         self.exiting_expression_test(True, True)
 
     @skipIfWindows
     @expectedFailureAll(oslist=["freebsd"], bugnumber="llvm.org/pr48414")
+    @expectedFailureNetBSD
     def test_exit_before_one_thread_no_unwind(self):
         """Test the case where we exit within the one thread timeout"""
         self.exiting_expression_test(True, False)

lldb/test/API/functionalities/thread/state_after_expression/TestStateAfterExpression.py

@@ -16,6 +16,7 @@ class TestStopReasonAfterExpression(TestBase):
 
     @skipIfWindows
     @expectedFailureAll(oslist=["freebsd"], bugnumber="llvm.org/pr48415")
+    @expectedFlakeyNetBSD
     def test_thread_state_after_expr(self):
         self.build()
         self.main_source_file = lldb.SBFileSpec("main.cpp")

lldb/test/API/functionalities/thread/thread_specific_break_plus_condition/TestThreadSpecificBpPlusCondition.py

@@ -20,7 +20,7 @@ class ThreadSpecificBreakPlusConditionTestCase(TestBase):
     # hits break in another thread in testrun
     @add_test_categories(['pyapi'])
     @expectedFailureAll(oslist=['ios', 'watchos', 'tvos', 'bridgeos'], archs=['armv7', 'armv7k'], bugnumber='rdar://problem/34563348') # Two threads seem to end up with the same my_value when built for armv7.
-    @expectedFailureNetBSD
+    @expectedFlakeyNetBSD
     def test_python(self):
         """Test that we obey thread conditioned breakpoints."""
         self.build()

lldb/test/API/functionalities/unwind/noreturn/TestNoreturnUnwind.py

@@ -18,7 +18,6 @@ class NoreturnUnwind(TestBase):
     # clang does not preserve LR in noreturn functions, making unwinding impossible
     @skipIf(compiler="clang", archs=['arm'], oslist=['linux'])
     @expectedFailureAll(bugnumber="llvm.org/pr33452", triple='^mips')
-    @expectedFailureNetBSD
     def test(self):
         """Test that we can backtrace correctly with 'noreturn' functions on the stack"""
         self.build()

lldb/test/API/lang/c/conflicting-symbol/TestConflictingSymbol.py

@@ -20,7 +20,6 @@ def setUp(self):
 
     @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24489")
     @expectedFailureAll(oslist=["freebsd"], bugnumber="llvm.org/pr48416")
-    @expectedFailureNetBSD
     def test_conflicting_symbols(self):
         self.build()
         exe = self.getBuildArtifact("a.out")

lldb/test/API/lang/c/const_variables/TestConstVariables.py

@@ -17,7 +17,6 @@ class ConstVariableTestCase(TestBase):
     @expectedFailureAll(
         oslist=["windows"],
         bugnumber="llvm.org/pr24489: Name lookup not working correctly on Windows")
-    @expectedFailureNetBSD
     def test_and_run_command(self):
         """Test interpreted and JITted expressions on constant values."""
         self.build()

lldb/test/API/lang/c/function_types/TestFunctionTypes.py

@@ -47,7 +47,6 @@ def test(self):
             ])
 
     @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
-    @expectedFailureNetBSD
     def test_pointers(self):
         """Test that a function pointer to 'printf' works and can be called."""
         self.build()

lldb/test/API/lang/c/global_variables/TestGlobalVariables.py

@@ -37,7 +37,6 @@ def test_without_process(self):
                     substrs=['42'])
 
     @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24764")
-    @expectedFailureNetBSD
     def test_c_global_variables(self):
         """Test 'frame variable --scope --no-args' which omits args and shows scopes."""
         self.build()

lldb/test/API/lang/c/shared_lib/TestSharedLib.py

@@ -34,12 +34,10 @@ def common_test_expr(self, preload_symbols):
             "expression GetMeASubFoo(my_foo_ptr)",
             startstr="(sub_foo *) $")
 
-    @expectedFailureNetBSD
     def test_expr(self):
         """Test that types work when defined in a shared library and forward-declared in the main executable"""
         self.common_test_expr(True)
 
-    @expectedFailureNetBSD
     def test_expr_no_preload(self):
         """Test that types work when defined in a shared library and forward-declared in the main executable, but with preloading disabled"""
         self.common_test_expr(False)

lldb/test/API/lang/cpp/exceptions/TestCPPExceptionBreakpoints.py

@@ -24,7 +24,6 @@ def setUp(self):
     @expectedFailureAll(
         oslist=["windows"],
         bugnumber="llvm.org/pr24538, clang-cl does not support throw or catch")
-    @expectedFailureNetBSD
     def test(self):
         """Test lldb exception breakpoint command for CPP."""
         self.build()

lldb/test/API/lang/cpp/namespace_definitions/TestNamespaceDefinitions.py

@@ -23,7 +23,6 @@ class NamespaceDefinitionsTestCase(TestBase):
         bugnumber="llvm.org/pr28948",
         oslist=['linux'], compiler="gcc", archs=['arm','aarch64'])
     @expectedFailureAll(oslist=["windows"])
-    @expectedFailureNetBSD
     def test_expr(self):
         self.build()
         self.common_setup()

lldb/test/API/lang/cpp/stl/TestStdCXXDisassembly.py

@@ -17,7 +17,6 @@ class StdCXXDisassembleTestCase(TestBase):
     mydir = TestBase.compute_mydir(__file__)
 
     @skipIfWindows
-    @expectedFailureNetBSD
     def test_stdcxx_disasm(self):
         """Do 'disassemble' on each and every 'Code' symbol entry from the std c++ lib."""
         self.build()

lldb/test/API/lang/cpp/this/TestCPPThis.py

@@ -21,7 +21,6 @@ class CPPThisTestCase(TestBase):
     @expectedFailureAll(
         oslist=["windows"],
         bugnumber="llvm.org/pr24489: Name lookup not working correctly on Windows")
-    @expectedFailureNetBSD
     def test_with_run_command(self):
         """Test that the appropriate member variables are available when stopped in C++ static, inline, and const methods"""
         self.build()

lldb/test/API/python_api/event/TestEvents.py

@@ -203,7 +203,7 @@ def run(self):
         bugnumber="llvm.org/pr23617 Flaky, fails ~1/10 cases")
     @skipIfWindows # This is flakey on Windows AND when it fails, it hangs: llvm.org/pr38373
     @expectedFailureAll(oslist=["freebsd"], bugnumber="llvm.org/pr48417")
-    @expectedFlakeyNetBSD
+    @expectedFailureNetBSD
     def test_add_listener_to_broadcaster(self):
         """Exercise some SBBroadcaster APIs."""
         self.build()

lldb/test/API/python_api/lldbutil/iter/TestRegistersIterator.py

@@ -23,6 +23,7 @@ def setUp(self):
             'main.cpp', '// Set break point at this line.')
 
     @add_test_categories(['pyapi'])
+    @expectedFailureNetBSD
     def test_iter_registers(self):
         """Test iterator works correctly for lldbutil.iter_registers()."""
         self.build()

lldb/test/API/python_api/thread/TestThreadAPI.py

@@ -41,7 +41,6 @@ def test_run_to_address(self):
     @add_test_categories(['pyapi'])
     @expectedFailureAll(oslist=["linux"], archs=['arm'], bugnumber="llvm.org/pr45892")
     @expectedFailureAll(oslist=["windows"])
-    @expectedFailureNetBSD
     def test_step_out_of_malloc_into_function_b(self):
         """Test Python SBThread.StepOut() API to step out of a malloc call where the call site is at function b()."""
         # We build a different executable than the default build() does.

lldb/test/API/tools/lldb-server/TestGdbRemote_vContThreads.py

@@ -52,6 +52,7 @@ def test_signal_one_thread_debugserver(self):
         self.signal_one_thread()
 
     @skipUnlessPlatform(["netbsd"])
+    @expectedFailureNetBSD
     @llgs_test
     def test_signal_one_thread_llgs(self):
         self.build()
@@ -79,6 +80,7 @@ def test_signal_all_threads_debugserver(self):
         self.signal_all_threads()
 
     @skipUnlessPlatform(["netbsd"])
+    @expectedFailureNetBSD
     @llgs_test
     def test_signal_all_threads_llgs(self):
         self.build()

lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_setExceptionBreakpoints.py

@@ -17,7 +17,6 @@ class TestVSCode_setExceptionBreakpoints(
     mydir = TestBase.compute_mydir(__file__)
 
     @skipIfWindows
-    @expectedFailureNetBSD
     @skipIfRemote
     def test_functionality(self):
         '''Tests setting and clearing exception breakpoints.

lldb/test/API/tools/lldb-vscode/disconnect/TestVSCode_disconnect.py

@@ -51,6 +51,7 @@ def test_launch(self):
     @skipIfDarwin
     @skipIfWindows
     @skipIfRemote
+    @expectedFailureNetBSD
     def test_attach(self):
         """
             This test attaches to a process that creates a file. We attach and disconnect

lldb/test/Shell/Recognizer/assert.test

@@ -1,5 +1,6 @@
 # XFAIL: target-arm && linux-gnu
 # XFAIL: system-freebsd
+# XFAIL: system-netbsd
 # UNSUPPORTED: system-windows
 # RUN: %clang_host -g -O0 %S/Inputs/assert.c -o %t.out
 # RUN: %lldb -b -s %s %t.out | FileCheck %s

lldb/test/Shell/Reproducer/Functionalities/TestExpressionEvaluation.test

@@ -1,5 +1,5 @@
 # UNSUPPORTED: system-freebsd
-# XFAIL: system-netbsd
+# UNSUPPORTED: system-netbsd
 
 # Flaky
 # UNSUPPORTED: system-linux

lldb/test/Shell/ScriptInterpreter/Lua/watchpoint_callback.test

@@ -1,4 +1,5 @@
 # REQUIRES: lua
+# XFAIL: system-netbsd
 # RUN: echo "int main() { return 0; }" | %clang_host -x c - -o %t
 # RUN: %lldb -s %s --script-language lua %t 2>&1 | FileCheck %s
 b main