Merged master:329abed10b8 into amd-gfx:92039d2cd59

Local branch amd-gfx 92039d2 Merged master:49a4f3f7d88 into amd-gfx:9c1698c4caf Remote branch master 329abed [lldb/Reproducers] Skip test that changes the source file while debugging
jaebaek · May 22, 2020 · dbabb2b · dbabb2b
2 parents 92039d2 + 329abed
commit dbabb2b
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 6 deletions.
diff --git a/lldb/test/API/python_api/watchpoint/TestSetWatchpoint.py b/lldb/test/API/python_api/watchpoint/TestSetWatchpoint.py
@@ -103,4 +103,9 @@ def test_watch_val(self):
             PROCESS_EXITED)
 
         self.dbg.DeleteTarget(target)
-        self.assertFalse(watchpoint.IsValid())
+
+        # The next check relies on the watchpoint being destructed, which does
+        # not happen during replay because objects are intentionally kept alive
+        # forever.
+        if not configuration.is_reproducer():
+            self.assertFalse(watchpoint.IsValid())
diff --git a/lldb/test/API/source-manager/TestSourceManager.py b/lldb/test/API/source-manager/TestSourceManager.py
@@ -172,6 +172,7 @@ def test_move_and_then_display_source(self):
                     substrs=['Hello world'])
 
     @skipIf(oslist=["windows"], bugnumber="llvm.org/pr44431")
+    @skipIfReproducer # VFS is a snapshot.
     def test_modify_source_file_while_debugging(self):
         """Modify a source file while debugging the executable."""
         self.build()

diff --git a/llvm/utils/gn/secondary/llvm/lib/Target/AArch64/BUILD.gn b/llvm/utils/gn/secondary/llvm/lib/Target/AArch64/BUILD.gn
@@ -24,18 +24,27 @@ tablegen("AArch64GenGlobalISel") {
   td_file = "AArch64.td"
 }
 
-tablegen("AArch64GenGICombiner") {
+tablegen("AArch64GenMCPseudoLowering") {
+  visibility = [ ":LLVMAArch64CodeGen" ]
+  args = [ "-gen-pseudo-lowering" ]
+  td_file = "AArch64.td"
+}
+
+tablegen("AArch64GenPostLegalizeGICombiner") {
   visibility = [ ":LLVMAArch64CodeGen" ]
   args = [
     "-gen-global-isel-combiner",
-    "-combiners=AArch64PreLegalizerCombinerHelper",
+    "-combiners=AArch64PostLegalizerCombinerHelper",
   ]
   td_file = "AArch64.td"
 }
 
-tablegen("AArch64GenMCPseudoLowering") {
+tablegen("AArch64GenPreLegalizeGICombiner") {
   visibility = [ ":LLVMAArch64CodeGen" ]
-  args = [ "-gen-pseudo-lowering" ]
+  args = [
+    "-gen-global-isel-combiner",
+    "-combiners=AArch64PreLegalizerCombinerHelper",
+  ]
   td_file = "AArch64.td"
 }
 
@@ -50,9 +59,10 @@ static_library("LLVMAArch64CodeGen") {
     ":AArch64GenCallingConv",
     ":AArch64GenDAGISel",
     ":AArch64GenFastISel",
-    ":AArch64GenGICombiner",
     ":AArch64GenGlobalISel",
     ":AArch64GenMCPseudoLowering",
+    ":AArch64GenPostLegalizeGICombiner",
+    ":AArch64GenPreLegalizeGICombiner",
     ":AArch64GenRegisterBank",
 
     # See https://reviews.llvm.org/D69130
@@ -104,6 +114,7 @@ static_library("LLVMAArch64CodeGen") {
     "AArch64MachineFunctionInfo.cpp",
     "AArch64MacroFusion.cpp",
     "AArch64PBQPRegAlloc.cpp",
+    "AArch64PostLegalizerCombiner.cpp",
     "AArch64PreLegalizerCombiner.cpp",
     "AArch64PromoteConstant.cpp",
     "AArch64RedundantCopyElimination.cpp",