Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote about string to handle colon #2

Merged
merged 1 commit into from
May 23, 2021
Merged

Quote about string to handle colon #2

merged 1 commit into from
May 23, 2021

Conversation

albertteoh
Copy link
Collaborator

@albertteoh albertteoh commented May 23, 2021 •
edited
Loading

Signed-off-by: albertteoh albert.teoh@logz.io

Which problem is this PR solving?

Short description of the changes

  • yaml interprets : as the beginning of a map or list, so we need to quote the string to escape the colon in the URL.

Quote about string to handle colon
a6f9076 
Signed-off-by: albertteoh <albert.teoh@logz.io>
@albertteoh albertteoh mentioned this pull request May 23, 2021
Merged
@yurishkuro yurishkuro merged commit a1bdd5a into jaegertracing:main May 23, 2021
@albertteoh albertteoh deleted the escape-colon-char branch May 23, 2021 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albertteoh @yurishkuro