Added doc about tracing the operator #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
JStickler
requested changes
Nov 22, 2019
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
|
@JStickler could you please review again? |
|
@JStickler, @objectiser , is this good to be merged? |
objectiser
approved these changes
Dec 4, 2019
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
|
PR updated. |
objectiser
reviewed
Dec 4, 2019
|
+1 to Gary's latest suggestions. Otherwise LGTM. |
…amespace as operator Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
|
PR updated. @JStickler it still shows your review as "requested changes", but based on your last message, there's nothing pending, right? |
|
@jpkrohling, you're good. LGTM for merging. |
JStickler
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR documents what's needed to get traces out of the Jaeger Operator. This new feature is being added as part of jaegertracing/jaeger-operator#738.
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de