-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jaeger] Have an ability to make collector svc headless #136
[jaeger] Have an ability to make collector svc headless #136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Left one suggestion to wrap the rendered value around an if statement.
Also please add the value in the REAME's values table.
@spacentropy are you planning to add the |
Hi. Sorry for the Loooooong delay. I've rebased the branch and applied the suggested changes. Thanks! |
Hi! Let's return to this. I've made the requested changes. Can we proceed to merging this? @pavelnikolov |
Signed-off-by: Gleb Lesnikov <g.lesnikov@dodopizza.com>
Signed-off-by: Gleb Lesnikov <g.lesnikov@dodopizza.com>
@pavelnikolov Thanks for the approval! Can you please merge? I've rebased & signed commits. |
@pavelnikolov Why did you remove loadBalancerIP field? If I plan to run only one instance of collector, i don't need Linkerd in front. It would be fully customizable if you wish to use k8s lb.
|
Hi.
gRPC client balancing requires headless services in order to work. More info here - https://kubernetes.io/blog/2018/11/07/grpc-load-balancing-on-kubernetes-without-tears/
This change allows to set collector service type to headless. We use it in production without problems.