This repository has been archived by the owner on May 23, 2024. It is now read-only.
Unset highest bit of traceID in probabilistic sampler #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes interconnection of ProbabilisticSampler.IsSampled and tracerOptions.RandomNumber: - RandomNumber accepts `func() uint64` and doesn't documents it should return 63bit integer - IsSampled performed check as if random number were 63bit integer. This fix (suggested by Yuri Shkuro) truncates highest bit before comparison in IsSampled, therefore it doesn't matter if random number is 63bit or 64bit. Signed-off-by: Sokolov Yura <funny.falcon@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #490 +/- ##
=======================================
Coverage 88.43% 88.43%
=======================================
Files 59 59
Lines 3581 3581
=======================================
Hits 3167 3167
Misses 303 303
Partials 111 111
Continue to review full report at Codecov.
|
|
I've added test for 64bit values |
golangcibot
reviewed
Mar 2, 2020
| sampled, tags := sampler.IsSampled(TraceID{Low: (testMaxID + 10) | 1<<63}, testOperationName) | ||
| assert.False(t, sampled) | ||
| assert.Equal(t, testProbabilisticExpectedTags, tags) | ||
| sampled, tags = sampler.IsSampled(TraceID{Low: (testMaxID - 20) | 1<<63}, testOperationName) |
There was a problem hiding this comment.
ineffectual assignment to tags (from ineffassign)
Signed-off-by: Sokolov Yura <funny.falcon@gmail.com>
yurishkuro
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes interconnection of ProbabilisticSampler.IsSampled and tracerOptions.RandomNumber:
func() uint64and doesn't documents it should return 63bit integerThis fix (suggested by Yuri Shkuro) truncates highest bit before comparison in IsSampled,
therefore it doesn't matter if random number is 63bit or 64bit.
fixes #489
Signed-off-by: Sokolov Yura funny.falcon@gmail.com