-
Notifications
You must be signed in to change notification settings - Fork 232
Conversation
CONTRIBUTING.md
Outdated
|
||
We gratefully welcome improvements to documentation as well as to code. | ||
|
||
# Certificate of Origin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this header need to be here? If you want to have a discussion of DCO before the details nearer the end, then possibly don't have the header - or else make it level 2?
@@ -1,23 +1,15 @@ | |||
/* | |||
* Copyright (c) 2016, Uber Technologies, Inc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be 2017? We can't apply the license retroactively, can we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the licensing terms does not change the copyright. There are only two files I corrected in this PR that had incorrect 2017 copyright, even though the files were written in 2016, so I changed them to 2016-2017.
* replace headers * add LICENSE, DCO, CONTRIBUTING.md * set default copyright to The Jaeger Authors for new files Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
583c7d5
to
fca8ece
Compare
Codecov Report
@@ Coverage Diff @@
## master #262 +/- ##
===========================================
+ Coverage 82.3% 82.6% +0.29%
Complexity 530 530
===========================================
Files 87 87
Lines 2006 2006
Branches 237 237
===========================================
+ Hits 1651 1657 +6
+ Misses 258 252 -6
Partials 97 97
Continue to review full report at Codecov.
|
Resolves #239
Signed-off-by: Yuri Shkuro ys@uber.com