Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Fix flaky test in RemoteReporterTest #415

Merged

Conversation

pavolloffay
Copy link
Member

Supersedes #385
Resolves #351

Signed-off-by: Pavol Loffay ploffay@redhat.com

@pavolloffay pavolloffay requested a review from jpkrohling May 16, 2018 10:42
@ghost ghost assigned pavolloffay May 16, 2018
@ghost ghost added the review label May 16, 2018
@codecov
Copy link

codecov bot commented May 16, 2018

Codecov Report

Merging #415 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #415   +/-   ##
=========================================
  Coverage     82.09%   82.09%           
  Complexity      490      490           
=========================================
  Files            66       66           
  Lines          2044     2044           
  Branches        247      247           
=========================================
  Hits           1678     1678           
  Misses          284      284           
  Partials         82       82

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61b5381...0803e64. Read the comment docs.

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@pavolloffay pavolloffay force-pushed the fix-flaky-zipkin-test-2 branch from 33a121d to 0803e64 Compare May 16, 2018 12:37
Copy link
Collaborator

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\o/

@pavolloffay
Copy link
Member Author

wuhaha 🌞

@pavolloffay pavolloffay merged commit 1542276 into jaegertracing:master May 16, 2018
@ghost ghost removed the review label May 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants