This repository has been archived by the owner on Jul 1, 2022. It is now read-only.
Do not use deprecated APIs internally #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #416 +/- ##
===========================================
- Coverage 82.24% 82.14% -0.1%
+ Complexity 487 486 -1
===========================================
Files 66 66
Lines 2033 2033
Branches 247 247
===========================================
- Hits 1672 1670 -2
- Misses 280 281 +1
- Partials 81 82 +1
Continue to review full report at Codecov.
|
|
I will merge this, There is no API change or in the code. It just swaps invocation of deprecated APIs to supported. |
pavolloffay
commented
May 16, 2018
| @@ -103,7 +104,7 @@ public void shutdown() throws ExecutionException, InterruptedException { | |||
| Iterator<NetworkListener> iterator = server.getListeners().iterator(); | |||
| while (iterator.hasNext()) { | |||
| NetworkListener next = iterator.next(); | |||
| next.shutdown(); | |||
| GrizzlyFuture<NetworkListener> shutdown = next.shutdown(); | |||
There was a problem hiding this comment.
This removes warning message from errorprone
/home/ploffay/projects/jaeger/jaeger-client-java/jaeger-crossdock/src/main/java/io/jaegertracing/crossdock/JerseyServer.java:106: warning: [FutureReturnValueIgnored] Return value of methods returning Future must be checked. Ignoring returned Futures suppresses exceptions thrown from the code that completes the Future.
next.shutdown();
^
(see http://errorprone.info/bugpattern/FutureReturnValueIgnored)
Did you mean to remove this line?
Note: /home/ploffay/projects/jaeger/jaeger-client-java/jaeger-crossdock/src/main/java/io/jaegertracing/crossdock/resources/behavior/EndToEndBehavior.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
1 warning
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pavol Loffay ploffay@redhat.com