-
Notifications
You must be signed in to change notification settings - Fork 231
Implement TracerFactory #527
Implement TracerFactory #527
Conversation
120d833
to
9e554a8
Compare
Codecov Report
@@ Coverage Diff @@
## master #527 +/- ##
============================================
+ Coverage 88.63% 88.64% +0.01%
- Complexity 515 517 +2
============================================
Files 66 67 +1
Lines 1891 1893 +2
Branches 243 243
============================================
+ Hits 1676 1678 +2
Misses 141 141
Partials 74 74
Continue to review full report at Codecov.
|
9e554a8
to
8f49203
Compare
I'm glad I ended up using |
8f49203
to
c858eba
Compare
Afaik codecov just works off the coverage files we send to it. Worth checking if the execution is being captured there first. |
@yurishkuro is correct here. You can inspect these files by clicking download on the codecov build view: https://codecov.io/gh/jaegertracing/jaeger-client-java/commit/c858eba8871b19269718525ab28b083e48446772/build @jpkrohling Maybe I'm reading the coverage number wrong, but to me it seems like codecov shows that the line is covered |
It shows the line as covered now, as I'm making an explicit call to the method, but it wasn't before. |
c858eba
to
a031641
Compare
I happen to agree that I've had my fair share of issues with codecov. Don't know if it stems from the language tooling or the codecov analysis. |
Still way better than coveralls |
a031641
to
bd90a65
Compare
Apart from the code coverage discussion, is this OK to get merged? |
...acerresolver/src/main/java/io/jaegertracing/tracerresolver/internal/JaegerTracerFactory.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
2fcf2ce
to
6458d45
Compare
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de
Which problem is this PR solving?
Short description of the changes
TracerFactory
interface, changing the current tracer resolver to get a tracer from this new class (so that we have only one place knowing how to create a tracer).