Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Add manifest entries to jaeger-thrift #641

Merged
merged 1 commit into from
Jul 30, 2019

Conversation

objectiser
Copy link
Contributor

Signed-off-by: Gary Brown gary@brownuk.com

Which problem is this PR solving?

Manifest entries are missing from the jaeger-thrift jars, as the task is being skipped for this module within the top level build.gradle.

Short description of the changes

Add manifest entries to the jaeger-thrift module.

Signed-off-by: Gary Brown <gary@brownuk.com>
@objectiser objectiser requested a review from jpkrohling July 30, 2019 07:55
Copy link
Collaborator

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but perhaps it can be added at a top-level project, adding those entries to all modules?

@objectiser
Copy link
Contributor Author

@jpkrohling It is added to the top level build.grade but with an exclusion for the jaeger-thrift module: https://github.com/jaegertracing/jaeger-client-java/blob/master/build.gradle#L197-L201

@codecov
Copy link

codecov bot commented Jul 30, 2019

Codecov Report

Merging #641 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #641   +/-   ##
=========================================
  Coverage     89.62%   89.62%           
  Complexity      564      564           
=========================================
  Files            69       69           
  Lines          2063     2063           
  Branches        262      262           
=========================================
  Hits           1849     1849           
  Misses          134      134           
  Partials         80       80

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43bfc75...48c436c. Read the comment docs.

@objectiser objectiser merged commit 0d4c675 into jaegertracing:master Jul 30, 2019
@objectiser objectiser deleted the thriftmanifest branch July 30, 2019 08:02
objectiser added a commit to objectiser/jaeger-client-java that referenced this pull request Jan 22, 2020
Signed-off-by: Gary Brown <gary@brownuk.com>
objectiser added a commit that referenced this pull request Jan 22, 2020
Signed-off-by: Gary Brown <gary@brownuk.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants