This repository has been archived by the owner on Jul 1, 2022. It is now read-only.
Java: Cleanup operation samplers if absent from strategy response #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vprithvi
reviewed
Oct 2, 2019
jaeger-core/src/main/java/io/jaegertracing/internal/samplers/PerOperationSampler.java
Outdated
Show resolved
Hide resolved
guo0693
changed the title
vprithvi
reviewed
Oct 2, 2019
jaeger-core/src/main/java/io/jaegertracing/internal/samplers/PerOperationSampler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: jung <jung@uber.com>
vprithvi
reviewed
Oct 2, 2019
| String absentOp = "ShouldBeRemoved"; | ||
| operationToSamplers.put(absentOp, mock(GuaranteedThroughputSampler.class)); | ||
| PerOperationSamplingParameters perOperationSamplingParameters1 = | ||
| new PerOperationSamplingParameters(OPERATION, new ProbabilisticSamplingStrategy(SAMPLING_RATE)); |
There was a problem hiding this comment.
Shouldn't operationToSamplers be passed in here to control the starting state of the test?
There was a problem hiding this comment.
undertest is inited with the operationToSamplers during setup, adding a sampler to the map should do the job regarding the starting state.
Codecov Report
@@ Coverage Diff @@
## master #655 +/- ##
===========================================
- Coverage 89.48% 89.4% -0.09%
Complexity 563 563
===========================================
Files 69 69
Lines 2073 2076 +3
Branches 263 263
===========================================
+ Hits 1855 1856 +1
- Misses 136 138 +2
Partials 82 82
Continue to review full report at Codecov.
|
vprithvi
approved these changes
Oct 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jung jung@uber.com
Which problem is this PR solving?
Short description of the changes