Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Add logging for SenderException in RemoteReporter #662

Merged
merged 1 commit into from
Oct 17, 2019

Conversation

esukram
Copy link
Contributor

@esukram esukram commented Oct 17, 2019

Which problem is this PR solving?

Closes #653

Short description of the changes

In order to get more context if a SenderException has been thrown, the complete exception is logged with error level.

In order to get more context if a SenderException has been thrown, the
complete exception is logged with `error` level.

Unit test has been added.

Signed-off-by: Markus Heimbach <markus@esukram.org>
@codecov
Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #662 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #662      +/-   ##
============================================
- Coverage     89.64%   89.59%   -0.05%     
+ Complexity      569      567       -2     
============================================
  Files            69       69              
  Lines          2085     2086       +1     
  Branches        266      266              
============================================
  Hits           1869     1869              
- Misses          134      135       +1     
  Partials         82       82
Impacted Files Coverage Δ Complexity Δ
...egertracing/internal/reporters/RemoteReporter.java 87.35% <100%> (+4.79%) 7 <0> (ø) ⬇️
...rtracing/internal/reporters/CompositeReporter.java 71.42% <0%> (-28.58%) 6% <0%> (-1%)
...gertracing/internal/reporters/LoggingReporter.java 81.81% <0%> (-9.1%) 4% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23a8223...f72e2b5. Read the comment docs.

@jpkrohling jpkrohling merged commit fd9f743 into jaegertracing:master Oct 17, 2019
@jpkrohling
Copy link
Collaborator

Thanks for your contribution!

@esukram esukram deleted the issue-653 branch October 17, 2019 09:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log SenderException errors in RemoteReporter
2 participants