This repository has been archived by the owner on Jul 1, 2022. It is now read-only.
upgrade GSON and slf4j-api version #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chandresh-pancholi <chandreshpancholi007@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #663 +/- ##
=========================================
Coverage 89.83% 89.83%
Complexity 569 569
=========================================
Files 69 69
Lines 2086 2086
Branches 266 266
=========================================
Hits 1874 1874
Misses 131 131
Partials 81 81Continue to review full report at Codecov.
|
|
@chandresh-pancholi please make sure the description not just references a ticket, but does it in the form that GitHub recognizes, e.g. |
jpkrohling
changed the title
jpkrohling
approved these changes
Oct 18, 2019
There was a problem hiding this comment.
LGTM, but I would like to get @objectiser's approval as well.
objectiser
approved these changes
Oct 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: chandresh-pancholi chandreshpancholi007@gmail.com
Resolves #651
Which problem is this PR solving?
Short description of the changes