Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Unregister shutdown hook when tracer is closed #679

Merged
merged 1 commit into from
Jan 8, 2020

Conversation

TomasHofman
Copy link
Contributor

Resolves #677

Signed-off-by: Tomas Hofman thofman@redhat.com

Which problem is this PR solving?

  • Avoid memory leak in JaegerTracer.

Short description of the changes

  • Unregister the shutdown hook when tracer is closed. (The hook is registered during tracer instance creation.)

Resolves jaegertracing#677

Signed-off-by: Tomas Hofman <thofman@redhat.com>
@pavolloffay pavolloffay changed the title [Issue-677] Memory leak - unregister shutdown hook when tracer is closed Unregister shutdown hook when tracer is closed Jan 8, 2020
@codecov
Copy link

codecov bot commented Jan 8, 2020

Codecov Report

Merging #679 into master will increase coverage by 0.15%.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #679      +/-   ##
============================================
+ Coverage     89.59%   89.75%   +0.15%     
- Complexity      567      570       +3     
============================================
  Files            69       69              
  Lines          2086     2089       +3     
  Branches        266      267       +1     
============================================
+ Hits           1869     1875       +6     
+ Misses          135      133       -2     
+ Partials         82       81       -1
Impacted Files Coverage Δ Complexity Δ
...n/java/io/jaegertracing/internal/JaegerTracer.java 88.01% <75%> (-0.92%) 26 <0> (ø)
...ing/internal/samplers/RemoteControlledSampler.java 92.5% <0%> (+1.25%) 17% <0%> (+1%) ⬆️
...gertracing/internal/reporters/LoggingReporter.java 90.9% <0%> (+9.09%) 5% <0%> (+1%) ⬆️
...rtracing/internal/reporters/CompositeReporter.java 100% <0%> (+28.57%) 7% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e1a618...54034a7. Read the comment docs.

@pavolloffay
Copy link
Member

@TomasHofman do you also need this fix in version 0.34.0?

@pavolloffay pavolloffay merged commit 4bde959 into jaegertracing:master Jan 8, 2020
@TomasHofman
Copy link
Contributor Author

@TomasHofman do you also need this fix in version 0.34.0?

That would be ideal, that's the version we are using in Wildfly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak in JaegerTracer
3 participants