Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Do not strip leading zeros from trace IDs #746

Merged
merged 3 commits into from
Sep 15, 2020

Conversation

Signed-off-by: Yuri Shkuro <github@ysh.us>
@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #746 into master will decrease coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #746      +/-   ##
============================================
- Coverage     89.10%   88.88%   -0.22%     
  Complexity      603      603              
============================================
  Files            73       73              
  Lines          2257     2259       +2     
  Branches        294      295       +1     
============================================
- Hits           2011     2008       -3     
- Misses          155      159       +4     
- Partials         91       92       +1     
Impacted Files Coverage Δ Complexity Δ
...a/io/jaegertracing/internal/JaegerSpanContext.java 98.03% <100.00%> (-0.08%) 31.00 <0.00> (-1.00)
...egertracing/internal/propagation/TextMapCodec.java 92.72% <100.00%> (ø) 36.00 <0.00> (+1.00)
...in/java/io/jaegertracing/internal/utils/Utils.java 86.36% <100.00%> (+3.03%) 8.00 <2.00> (+2.00)
...rtracing/internal/reporters/CompositeReporter.java 71.42% <0.00%> (-28.58%) 6.00% <0.00%> (-1.00%)
...gertracing/internal/reporters/LoggingReporter.java 81.81% <0.00%> (-9.10%) 4.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3296585...b92510e. Read the comment docs.

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro merged commit 640fa35 into jaegertracing:master Sep 15, 2020
@yurishkuro yurishkuro deleted the pad-trace-id-with-zeros branch September 15, 2020 15:37
JoakimLofgren added a commit to JoakimLofgren/java-spring-jaeger that referenced this pull request May 5, 2021
pavolloffay pushed a commit to opentracing-contrib/java-spring-jaeger that referenced this pull request Jun 3, 2021
* Bump jaeger client

Fixes #121

See jaegertracing/jaeger-client-java#768

* Add throws for new Exception from Jaeger client

Also fix assert to not strip leading zeros,
see jaegertracing/jaeger-client-java#746
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky unit test io.jaegertracing.zipkin.internal.V2SpanConverterTest#testConvertSpanWith128BitTraceId
2 participants