Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Add github action for publish to sonatype #776

Closed
wants to merge 1 commit into from

Conversation

Ashmita152
Copy link
Contributor

@Ashmita152 Ashmita152 commented Mar 27, 2021

Signed-off-by: Ashmita Bohara ashmita.bohara152@gmail.com

Which problem is this PR solving?

Add GitHub Action for publishing to Sonatype.

Short description of the changes

I have to still test this PR from my fork. Still trying to figure out steps to test it. Meanwhile opening the PR to get feedbacks.

It expects following secrets to be available to the job:

  • ENCRYPTION_IV
  • ENCRYPTION_KEY
  • SIGNING_KEY_ID
  • SIGNING_KEY_PASSPHRASE
  • SONATYPE_USERNAME
  • SONATYPE_PASSWORD

Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com>
@codecov
Copy link

codecov bot commented Mar 27, 2021

Codecov Report

Merging #776 (3a662a2) into master (6b314cd) will decrease coverage by 0.07%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #776      +/-   ##
============================================
- Coverage     89.11%   89.03%   -0.08%     
  Complexity      605      605              
============================================
  Files            73       73              
  Lines          2259     2261       +2     
  Branches        295      295              
============================================
  Hits           2013     2013              
- Misses          155      157       +2     
  Partials         91       91              
Impacted Files Coverage Δ Complexity Δ
...egertracing/zipkin/internal/ThriftSpanEncoder.java 70.58% <33.33%> (-9.42%) 4.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f828cf...3a662a2. Read the comment docs.

@Ashmita152 Ashmita152 changed the title Add github action for pub to sonatype Add github action for publish to sonatype Mar 27, 2021
@yurishkuro
Copy link
Member

One thing worth remembering is that the release process does two commits, if I am not mistaken, one to change the version to release number, another to change it back to "snapshot". So the gh action may need to run several times, not just on release-* tag.

Btw, I tried to make gh action work with committing changes to the repo in the docs, and gave up after couple hours. Hopefully you can find a solution. May be worth experimenting on a test repo.

@Ashmita152
Copy link
Contributor Author

Hi @yurishkuro

Thank you for the point about release process of this repo. I will validate it.

Btw, I tried to make gh action work with committing changes to the repo in the docs, and gave up after couple hours. Hopefully you can find a solution. May be worth experimenting on a test repo.

Sorry Yuri, I didn't get this part. Are we talking about some issue with GH Actions of this repo that was added in the last PR ?

@yurishkuro
Copy link
Member

I'm referring to documentation repo, which also does commits during the release process. It used to work in Travis, but since switching to GHA the release commits cannot be pushed.

@Ashmita152
Copy link
Contributor Author

Ashmita152 commented Mar 27, 2021

Sure Yuri, I will see if I can find fix for it with a test repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants