This repository has been archived by the owner on Jul 1, 2022. It is now read-only.
[ISSUE-778]: RemoteReporter should be able to 'ignore' sender exception as in old behaviour. #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as in old behaviour. * Adding a new ignoreSenderErrors to the ReporterConfiguration. * tracing sender errors in debug if ignoreSenderErrors is set to true in RemoteReporter. Issue: jaegertracing#778 Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #779 +/- ##
============================================
- Coverage 89.03% 89.00% -0.03%
- Complexity 605 607 +2
============================================
Files 73 73
Lines 2261 2274 +13
Branches 295 296 +1
============================================
+ Hits 2013 2024 +11
- Misses 157 158 +1
- Partials 91 92 +1
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By setting ReporterConfiguration.ignoreSenderErrors to true we can use the old behaviour bu logging a DEBUG message.
Otherwise (defualt) we keep the current one and log a WARN message.
Resolves #778